Do not set pluginUntilBuild to allow using with future releases #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow using the same plugin with future IntelliJ releases and fix sudison#1. Briefly looking e.g. discussion at https://intellij-support.jetbrains.com/hc/en-us/community/posts/360010590059-Why-pluginUntilBuild-is-mandatory it seems that this is acceptable approach but validity against future releases should be checked using intellij-plugin-verifier. As of writing, the current latest version number is 202 matching JetBrains products 2021.2.*. The output of the intellij-plugin-verifier says this plugin is still compatible: 2021-11-10T21:03:56 [main] INFO verification - Finished 1 of 1 verifications (in 2.6 s): IU-212.5457.46 against org.zig:0.3.1: Compatible. 3 usages of deprecated API. 1 usage of internal API Plugin org.zig:0.3.1 against IU-212.5457.46: Compatible. 3 usages of deprecated API. 1 usage of internal API Deprecated API usages (3): \#Deprecated method com.intellij.openapi.util.IconLoader.getIcon(String) invocation Deprecated method com.intellij.openapi.util.IconLoader.getIcon(java.lang.String path) : javax.swing.Icon is invoked in org.zig.ZigIcons.<clinit>() : void \#Deprecated method com.intellij.openapi.project.Project.getBaseDir() invocation Deprecated method com.intellij.openapi.project.Project.getBaseDir() : com.intellij.openapi.vfs.VirtualFile is invoked in org.zig.runner.ZigCompilerOutputFilter.applyFilter(String, int) : Filter.Result \#Deprecated method com.intellij.lang.ParserDefinition.spaceExistanceTypeBetweenTokens(ASTNode, ASTNode) is overridden Deprecated method com.intellij.lang.ParserDefinition.spaceExistanceTypeBetweenTokens(com.intellij.lang.ASTNode left, com.intellij.lang.ASTNode right) : com.intellij.lang.ParserDefinition.SpaceRequirements is overridden in class org.zig.ZigParserDefinition Internal API usages (1): \#Internal method com.intellij.execution.ExecutionManager.startRunProfile(ExecutionEnvironment, Function0) invocation Internal method com.intellij.execution.ExecutionManager.startRunProfile(com.intellij.execution.runners.ExecutionEnvironment arg0, kotlin.jvm.functions.Function0 arg1) : void is invoked in org.zig.runner.ZigRunner.execute(ExecutionEnvironment) : void. This method is marked with @org.jetbrains.annotations.ApiStatus.Internal annotation and indicates that the method is not supposed to be used in client code. Plugin can be loaded/unloaded without IDE restart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow using the same plugin with future IntelliJ releases
and fix #1.
Briefly looking e.g. discussion at https://intellij-support.jetbrains.com/hc/en-us/community/posts/360010590059-Why-pluginUntilBuild-is-mandatory
it seems that this is acceptable approach but validity
against future releases should be checked using intellij-plugin-verifier.
As of writing, the current latest version number is 202 matching
JetBrains products 2021.2.*.
The output of the intellij-plugin-verifier says this plugin is still compatible:
2021-11-10T21:03:56 [main] INFO verification - Finished 1 of 1 verifications (in 2.6 s): IU-212.5457.46 against org.zig:0.3.1: Compatible. 3 usages of deprecated API. 1 usage of internal API
Plugin org.zig:0.3.1 against IU-212.5457.46: Compatible. 3 usages of deprecated API. 1 usage of internal API
Deprecated API usages (3):
#Deprecated method com.intellij.openapi.util.IconLoader.getIcon(String) invocation
Deprecated method com.intellij.openapi.util.IconLoader.getIcon(java.lang.String path) : javax.swing.Icon is invoked in org.zig.ZigIcons.() : void
#Deprecated method com.intellij.openapi.project.Project.getBaseDir() invocation
Deprecated method com.intellij.openapi.project.Project.getBaseDir() : com.intellij.openapi.vfs.VirtualFile is invoked in org.zig.runner.ZigCompilerOutputFilter.applyFilter(String, int) : Filter.Result
#Deprecated method com.intellij.lang.ParserDefinition.spaceExistanceTypeBetweenTokens(ASTNode, ASTNode) is overridden
Deprecated method com.intellij.lang.ParserDefinition.spaceExistanceTypeBetweenTokens(com.intellij.lang.ASTNode left, com.intellij.lang.ASTNode right) : com.intellij.lang.ParserDefinition.SpaceRequirements is overridden in class org.zig.ZigParserDefinition
Internal API usages (1):
#Internal method com.intellij.execution.ExecutionManager.startRunProfile(ExecutionEnvironment, Function0) invocation
Internal method com.intellij.execution.ExecutionManager.startRunProfile(com.intellij.execution.runners.ExecutionEnvironment arg0, kotlin.jvm.functions.Function0 arg1) : void is invoked in org.zig.runner.ZigRunner.execute(ExecutionEnvironment) : void. This method is marked with @org.jetbrains.annotations.ApiStatus.Internal annotation and indicates that the method is not supposed to be used in client code.
Plugin can be loaded/unloaded without IDE restart